Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Fixes for olympus swaps#1202

Merged
AnthonyRonning merged 1 commit into
masterfrom
zeus-swap-fixes
Jun 6, 2024
Merged

Fixes for olympus swaps#1202
AnthonyRonning merged 1 commit into
masterfrom
zeus-swap-fixes

Conversation

@benthecarman

@benthecarman benthecarman commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

Previously when doing a swap we'd get an extra channel sometimes because we'd call the fee api multiple time which would cause the olympus node to open the extra channel. To make sure we only call the fee api once, we need to generate the invoice when estimating fee and then when we execute the swap, use that invoice, this way we can guarantee there is only a single call to the api for a given swap.

For testing use this: https://mutinynet-lsps1.lnolymp.us

I tested:

  • fedimint -> lightning w/ no channels
  • fedimint -> lightning w/ channel and enough inbound
  • fedimint -> lightning w/ channel and not enough inbound
  • fedimint -> fedimint

@benthecarman benthecarman added the bug Something isn't working label Jun 6, 2024
@AnthonyRonning

Copy link
Copy Markdown
Contributor

Does this still work with the voltage LSP?

@benthecarman

Copy link
Copy Markdown
Collaborator Author

Does this still work with the voltage LSP?

yes

@AnthonyRonning AnthonyRonning merged commit e2a469b into master Jun 6, 2024
@AnthonyRonning AnthonyRonning deleted the zeus-swap-fixes branch June 6, 2024 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants